Fix array_use_braces for body params #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikolya
force-pushed
the
fix-array-use-braces-for-body-params
branch
from
277831b to
bf22627
Compare
Previously this is what was generated:
`"attr":{"type":"array","items":{"type":"object","properties":{"":{"type":"string"}}}}`
instead of
`"attr":{"type":"array","items":{"type":"string"}}`
in case this attribute was nested in a Hash attribute with "body" in `param_type`
bikolya
force-pushed
the
fix-array-use-braces-for-body-params
branch
from
bf22627 to
89f113b
Compare
LeFnord
reviewed
Sep 5, 2019
| def array_use_braces?(options) | ||
| settings[:array_use_braces] && !(options[:documentation] && options[:documentation][:param_type] == 'body') | ||
| def array_use_braces? | ||
| @array_use_braces ||= settings[:array_use_braces] && !includes_body_param? |
There was a problem hiding this comment.
where are the settings come from, is it configurable?
if yes, then it should be described in the README
There was a problem hiding this comment.
It's described here: https://github.com/ruby-grape/grape-swagger#array_use_braces
|
thanks @bikolya … |
aka-momo
pushed a commit
to aka-momo/grape-swagger
that referenced
this pull request
Feb 8, 2023
Previously this is what was generated:
`"attr":{"type":"array","items":{"type":"object","properties":{"":{"type":"string"}}}}`
instead of
`"attr":{"type":"array","items":{"type":"string"}}`
in case this attribute was nested in a Hash attribute with "body" in `param_type`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this is what was generated:
"attr":{"type":"array","items":{"type":"object","properties":{"":{"type":"string"}}}}instead of
"attr":{"type":"array","items":{"type":"string"}}in case this attribute was nested in a Hash attribute with "body" in
param_typeDefinition:
Here is how it looked like it Swagger UI:
instead of
