Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix misleading typo in README: notes -> detail #672

Merged
merged 4 commits into from
Mar 31, 2018
Merged

fix misleading typo in README: notes -> detail #672

merged 4 commits into from
Mar 31, 2018

Conversation

kjleitz
Copy link
Contributor

@kjleitz kjleitz commented Mar 30, 2018

Fixes #648

@coveralls
Copy link

coveralls commented Mar 30, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.257% when pulling 5ba7d21 on kjleitz:update-readme-notes-to-detail into 6402c2c on ruby-grape:master.

LeFnord
LeFnord reviewed Mar 30, 2018
View reviewed changes
CHANGELOG.md Outdated
@@ -4,6 +4,7 @@

* [#667](https://github.com/ruby-grape/grape-swagger/pull/667): Make route summary optional - [@obduk](https://github.com/obduk).
* [#670](https://github.com/ruby-grape/grape-swagger/pull/670): Add support for deprecated field - [@ioanatia](https://github.com/ioanatia).
* [#672](https://github.com/ruby-grape/grape-swagger/pull/672): Rename 'notes' to 'detail' in README - [@kjleitz](https://github.com/kjleitz).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move it to FIX

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LeFnord
Copy link
Member

LeFnord commented Mar 31, 2018

thanks @kjleitz

@LeFnord LeFnord merged commit f72d5e0 into ruby-grape:master Mar 31, 2018
LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
@kjleitz @LeFnord
fix misleading typo in README: notes -> detail (ruby-grape#672)
3ac17d6 
* fix misleading typo in README: notes -> detail

* fix spacing in log of 667, move log of 672 to 'Fixes'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeFnord LeFnord LeFnord left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjleitz @coveralls @LeFnord