Default success codes to be excluded when http_codes define one already #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakinj
force-pushed
the
endpoint-status-codes
branch
from
1f65109 to
35ca182
Compare
LeFnord
requested changes
Oct 22, 2017
| let(:app) do | ||
| Class.new(Grape::API) do | ||
| desc 'Has explicit http_codes defined' do | ||
| http_codes [{ code: 202, message: 'We got it!' }, |
There was a problem hiding this comment.
what's happened if we have mixed codes, something like this:
http_codes [
{ code: 200, message: 'all fine' },
{ code: 404, message: 'Not found' }
]maybe adding a spec to document the behaviour
There was a problem hiding this comment.
I've added some more status codes combinations to the specs
anakinj
force-pushed
the
endpoint-status-codes
branch
from
35ca182 to
a38c704
Compare
…es define one already
anakinj
force-pushed
the
endpoint-status-codes
branch
from
a38c704 to
1aab0ee
Compare
LeFnord
approved these changes
Oct 23, 2017
|
thanks @anakinj |
hara-y-u
pushed a commit
to hara-y-u/grape-swagger
that referenced
this pull request
Dec 8, 2017
…dy (ruby-grape#641) * Do not include the default success codes to the responses if http_codes define one already * Added spec with success and error codes
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
…dy (ruby-grape#641) * Do not include the default success codes to the responses if http_codes define one already * Added spec with success and error codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to override a POSTs default 201 status code. This change will prevent the default success code to be added if the http_codes array already include a success code.