Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of mounts with overrides #631

Merged
merged 2 commits into from
Sep 26, 2017

Conversation

adie
Copy link
Contributor

@adie adie commented Sep 11, 2017

The problem is that grape executes endpoints in the order of definition (like defined first - matched first), but documentation was showing information from the last defined endpoints.
Not sure if it's issue with the grape itself, but I think grape-swagger should be consistent with current state of grape gem.

@adie adie force-pushed the order-of-mount-overrides branch from f537d74 to 03bcb97 Compare September 11, 2017 21:17
@adie adie force-pushed the order-of-mount-overrides branch from 03bcb97 to 75117e6 Compare September 11, 2017 23:11
@coveralls
Copy link

coveralls commented Sep 11, 2017

Coverage Status

Coverage remained the same at 97.644% when pulling 75117e6 on Fuseit:order-of-mount-overrides into e9d9447 on ruby-grape:master.

@ruby-grape ruby-grape deleted a comment from coveralls Sep 26, 2017
@ruby-grape ruby-grape deleted a comment from coveralls Sep 26, 2017
@ruby-grape ruby-grape deleted a comment from coveralls Sep 26, 2017
@LeFnord
Copy link
Member

LeFnord commented Sep 26, 2017

thanks @adie … think it isn't really a 'problem' cause the documentation itself is a JSON and the the path section is a kind of a hash, so it has no order 😉 … but yeah, why not

@coveralls
Copy link

coveralls commented Sep 26, 2017

Coverage Status

Coverage remained the same at 97.316% when pulling 0304878 on Fuseit:order-of-mount-overrides into 7d871ae on ruby-grape:master.

@LeFnord LeFnord merged commit 89166b0 into ruby-grape:master Sep 26, 2017
@adie adie deleted the order-of-mount-overrides branch September 27, 2017 08:55
hara-y-u pushed a commit to hara-y-u/grape-swagger that referenced this pull request Dec 8, 2017
LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants