Allow body parameter name to be specified #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwp
force-pushed
the
salsify/body-name
branch
3 times, most recently
from
bd30160 to
9127a2f
Compare
|
Changes Unknown when pulling 9127a2f on salsify:salsify/body-name into ** on ruby-grape:master**. |
LeFnord
approved these changes
May 5, 2017
| @@ -42,9 +42,9 @@ def parent_definition_of_params(params, path, route) | |||
|
|
|||
| move_params_to_new(definition, params) | |||
|
|
|||
| definition[:description] = route.description if route.respond_to?(:description) | |||
| definition[:description] = route.description if route.try(:description).present? | |||
There was a problem hiding this comment.
think the present? isn't needed here
CHANGELOG.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| #### Features | |||
|
|
|||
| * Your contribution here. | |||
|
@LeFnord feedback addressed. Thanks for the quick review! |
|
thanks for the quick response 😄 |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For deeply nested resources, the generated name for a body parameter, based on the operation, can get very long. This change allows the generated name to be overridden using a
:body_nameoption on the desc.While adding tests for this, I found that the relevant specs used a
Grape::Requestwhile the actual object that is passed is aGrape::Router::Route, so they are updated accordingly.