use route_settings for hidden and operations extensions #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will give it a try and a deeper look on the weekend, ok? |
|
@LeFnord what do you think about this approach? |
LeFnord
reviewed
May 10, 2017
grape-swagger.gemspec
Outdated
| @@ -14,7 +14,7 @@ Gem::Specification.new do |s| | |||
| s.license = 'MIT' | |||
|
|
|||
| s.required_ruby_version = '>= 2.2.6' | |||
| s.add_runtime_dependency 'grape', '>= 0.16.2' | |||
| s.add_runtime_dependency 'grape', '>= 0.19.1' | |||
LeFnord
reviewed
May 10, 2017
| @@ -337,7 +337,8 @@ def model_name(name) | |||
| end | |||
|
|
|||
| def hidden?(route, options) | |||
| route_hidden = route.options[:hidden] | |||
| route_hidden = route.settings.try(:[], :swagger).try(:[], :hidden) | |||
| route_hidden = route.options[:hidden] if route.options.key?(:hidden) | |||
There was a problem hiding this comment.
am I right, the original behavior still available?
There was a problem hiding this comment.
Yeah, the original behavior is default.
LeFnord
reviewed
May 10, 2017
| @@ -19,10 +19,11 @@ class ExtensionsApi < Grape::API | |||
| { 'declared_params' => declared(params) } | |||
| end | |||
|
|
|||
| route_setting :x_operation, some: 'stuff' | |||
There was a problem hiding this comment.
I like it, makes the extensions more consistent, thanks
LeFnord
requested changes
May 10, 2017
|
👍 @thogg4 please add the changelog entry, then I'll mörge it |
LeFnord
approved these changes
May 10, 2017
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
* use route_settings for hidden and operations extensions * remove puts statements * revert grape version * add some details to the readme * add route to demonstrate how to hide endpoint with route settings * correct hide with route setting in readme * add changelog entry * remove curly braces for rubocop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LeFnord This pr may be a little heavy handed, but I wanted to show you what I meant by having grape-swagger use the preferred way to pass route settings.
Please let me know what you think and what I can improve and change.
Addresses #594