allow overriding tag definitions #589
Conversation
|
thanks @mattyr … but please have in mind, that the generation of the tags in grape-swagger are strongly related to the paths and an overriding of it is actual implemented, see: overriding-the-tags |
|
I did see that, however what I was looking to do was decouple that logic (if wanted). As it stands, it appears that the tag description is still fixed as "Operations about xxxxx", even if you reassign arbitrary tags to a path (correct me if i'm wrong!). The goal here is to still allow the existing "overriding-the-tags" (just re-assigning the tags), but allow the actual tag definitions (primarily the description) to be customized. |
mattyr
force-pushed
the
customizable-tags
branch
from
a3233fa to
2f421d6
Compare
|
Changes Unknown when pulling 2f421d6 on mattyr:customizable-tags into ** on ruby-grape:master**. |
spec/swagger_v2/default_api_spec.rb
Outdated
| end | ||
| add_swagger_documentation tags: [ | ||
| { name: 'something', description: 'customized description' } | ||
| ] |
There was a problem hiding this comment.
please can you add a second tag, so that it will be clear, that an existing tag can be overwritten and non-existing will be added, but only if I understand the tag description of the swagger-object right, please correct me, if I'm wrong, many thanks
There was a problem hiding this comment.
you're right, pushing a revised spec
|
@mattyr … please can you force push, to start travis, thanks |
|
done -- @LeFnord out of curiosity, do you not have access to the travis ci to just restart the builds there? |
|
Changes Unknown when pulling 393dc1b on mattyr:customizable-tags into ** on ruby-grape:master**. |
|
Hi @mattyr yeap I have access, but there was no build to restart … say only s3 😉 |
|
haha gotcha. good ol' aws. |
* allow overriding tag definitions * add changelog, address rubocop issues * add second tag to customized tag spec to make spec clearer * bump travis
So you're not stuck with "Operations about xxxxxx"