Use an automated PR linter, danger.systems. #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,3 +15,5 @@ if RUBY_VERSION < '2.2.2' | |||
| gem 'rack', '<2.0.0' | |||
| gem 'activesupport', '<5.0.0' | |||
| end | |||
|
|
|||
| gem 'danger', '~> 2.0' | |||
There was a problem hiding this comment.
Maybe adding required: false, so not to introduce unwanted dependency?
dblock
force-pushed
the
danger-systems
branch
3 times, most recently
from
534cc19 to
17e9bfb
Compare
|
Looks like danger use redcarpet only for markdown parsing, this not possible with jruby, should be: unless RUBY_PLATFORM == 'java'
gem 'danger', '~> 2.0', require: false
end |
|
I opened danger/danger#394 for Danger + JRuby, thanks @Bugagazavr. |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
LeFnord
added a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
corrects URLs of ruby-grape#419 and ruby-grape#486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll iterate on this...