options[:version] missing, changed to route.version. #438
Conversation
|
please use the same pattern for |
|
Done. |
texpert
changed the title
|
This most definitely needs a spec, too. |
|
Made a spec, at last :) |
|
Seems to be in good shape now. |
|
👍 |
| @@ -2,7 +2,7 @@ module GrapeSwagger | |||
| module DocMethods | |||
| class PathString | |||
| class << self | |||
| def build(path, options = {}) | |||
| def build(path, route_version, options = {}) | |||
There was a problem hiding this comment.
Maybe it'd be cleaner if this received the entire route? So def build(route, options = {})?
There was a problem hiding this comment.
It was my first thought eca701f but the PathString specs would need then some complex route initialization.
There was a problem hiding this comment.
You can make the request an OpenStruct in the spec, it will actually look simpler I think. API > spec anyway.
|
It looks good, still needs a CHANGELOG entry and possibly a README update. |
|
Now it is clean, the specs updated, CHANGELOG entry added. |
|
👍 |
|
Merged, 👍 |
…ions options[:version] missing, changed to route.version.
A small change, because the :version is missing in options, but I've found it in route.options. So better to pass the route to PathString - to have it there for .path and .options