Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary field #434

Merged
merged 1 commit into from
May 23, 2016
Merged

Conversation

aschuster3
Copy link
Contributor

A redo of PR #431, but with just summary. I will add deprecated later.

Between Swagger v1.2 and v2, the description took a slightly different meaning and summary took it's place. I had to re-work a handful of tests so that summary was accepted and in order to be somewhat forward compatible, I made the string passed to desc on paths fill in the value for the summary by default with the option to override it.

@aschuster3 aschuster3 force-pushed the add-summary-field branch 2 times, most recently from c048a69 to 78d5372 Compare May 20, 2016 23:02
@LeFnord
Copy link
Member

LeFnord commented May 20, 2016

👍

@@ -2,12 +2,10 @@

#### Features

* Your contribution here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this back please!

@aschuster3 aschuster3 force-pushed the add-summary-field branch 2 times, most recently from cd8b424 to 88448cd Compare May 21, 2016 14:25
@dblock
Copy link
Member

dblock commented May 21, 2016

Squash the commits? @LeFnord I'm cool with this, feel free to merge.

@aschuster3 aschuster3 force-pushed the add-summary-field branch from 88448cd to a6ef9c5 Compare May 22, 2016 17:37
@LeFnord LeFnord merged commit dd4ba4a into ruby-grape:master May 23, 2016
LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants