Added head method type #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs tests and a CHANGELOG entry, please. |
|
@dblock ok, when i should place spec? |
|
You mean where? I am not sure. You'll have to find a good place, there has been a lot of changes on master I am not too familiar with the updated structure. |
|
done |
|
Merged. Is it the same problem for OPTIONS? Want to take care of it? |
|
yep, but this problem can be solved, by nil check before https://github.com/ruby-grape/grape-swagger/blob/master/lib/grape-swagger/endpoint.rb#L164 |
|
@Bugagazavr write some specs, make some PRs! Much appreciated. |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
Fix: HEAD method support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grape swagger fails to generate doc if head route exists