Fixes paths that starts with mount path followed by dash #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasseebert
force-pushed
the
path_clash_with_hidden_docs
branch
from
8d02845 to
3d8165c
Compare
| @@ -31,7 +31,8 @@ def add_swagger_documentation(options = {}) | |||
| next if resource.empty? | |||
| resource.downcase! | |||
| @target_class.combined_routes[resource] ||= [] | |||
| next if documentation_class.hide_documentation_path && route.route_path.match(/#{documentation_class.mount_path}(\W|$)/) | |||
| next if documentation_class.hide_documentation_path && route.route_path.match(/#{documentation_class.mount_path}($|\/|\(\.)/) | |||
| p route.route_path | |||
lasseebert
force-pushed
the
path_clash_with_hidden_docs
branch
from
3d8165c to
0ccb330
Compare
|
Thanks for the review :) |
dblock
added a commit
that referenced
this pull request
Jun 22, 2015
Fixes paths that starts with mount path followed by dash
|
Merged, thanks! |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to https://github.com/tim-vandecasteele/grape-swagger/pull/260
There is still a bug in which too many endpoints are hidden when documentation path is hidden.
Changed regex to only disallow
Specifically, I still had a bug if an endpoint has
"#{mount_point}-"in it. See the spec.