Make compatible with grape 0.9.1 #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thanks. I'd appreciate if you could squash these and fix the build, pointing to 0.9.1 that hasn't shipped is probably too early ;) |
|
Do these changes, the use of namespace_stackable etc, not make it incompatible with 0.9.0? I must admit I didn't check. EDIT: ah i see, it breaks travis because it cant get the gem. how can I make this pass then, if it does indeed no longer work with 0.9.0? should I try and make it backwards compatible? |
|
Yes. I think we should make sure we have a release of grape-swagger that works with 0.9.0, and then do something for next. Mainly I am looking for a PR that will test grape-swagger against multiple versions of Grape, first. I plan to work on that soon. |
|
This has been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly self explanatory. Seems to work fine. Note that the master branch of grape has some bugs of its own, which I have also made a pull request against.