-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should be able to override the generated nicknames #100
Conversation
This seems very custom. Why would you want a nickname for an endpoint? |
The nickname is a required field for swagger. Swagger-codegen is already I can send you a few examples if that would help. https://github.com/wordnik/swagger-spec/blob/master/schemas/v1.2/operationObject.json On Mon, Jul 14, 2014 at 8:10 AM, Daniel Doubrovkine (dB.) @dblockdotorg <
|
Got it. Can you please rebase this, I'll merge. |
Sure thing, I'll get to this today... On Mon, Jul 14, 2014 at 9:27 AM, Daniel Doubrovkine (dB.) @dblockdotorg <
|
Ok, this should be done. I'm fairly new to github, let me know if you have On Mon, Jul 14, 2014 at 10:03 AM, Leon Horne leon@maginatics.com wrote:
|
@@ -1,5 +1,6 @@ | |||
### Next Release | |||
|
|||
* [#100] Adding ability to specify a nickname for an endpoint - [@lhorne](https://github.com/lhorne). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this identical to the lines below. This is missing a link after the [#100](.. here ...)
.
Sorry, I forgot to ask (too many PRs) - this needs a test, too. |
Swagger has a nickname filed specified in the 1.2 standard. It is used to generate an alternate name for code generators to use for that api. This patch provides a way to override the generated nickname with one specified in the grape documentation. Example: desc( 'Get all the cloud profiles in the system', :nickname => 'getAllCloudProfiles', )
I've added the test you requested, let me know if you need anything else done. |
Merging, thanks. |
Should be able to override the generated nicknames
Currently we have to accept the nickname that is auto generated for each operation. It would be nice to be able to specify a nickname in the endpoint directly.
/Leon
Fixing CHANGELOG.markdown to accout for the 0.7.2 release,
Adding override of auto generated nickname.