Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api key default value #82

Merged
merged 7 commits into from
May 30, 2017
Merged

Fix api key default value #82

merged 7 commits into from
May 30, 2017

Conversation

konto-andrzeja
Copy link
Contributor

Fixed this issue.

@konto-andrzeja
Copy link
Contributor Author

Maybe there's a way to keep ruby 2.0.0 compatibility without locking gem versions, but I think that the best approach would be to drop support for that old ruby version, since it causes too many problems.

@dblock
Copy link
Member

dblock commented May 30, 2017

This is great, I am going to merge this. Feel free to just drop ruby 2.0 support in a future PR.

@dblock dblock merged commit f5ad4bc into ruby-grape:master May 30, 2017
aske pushed a commit to aske/grape-swagger-rails that referenced this pull request Jun 6, 2017
@aske
Fix api key default value (ruby-grape#82)
e116b36 
* add failing spec

* fix adding api_key_default_value to headers

* update changelog

* bump rubocop to fix rake issue

* add geckodriver to fix issues with new selenium-webdriver

* fix specs

* change gem versions to keep ruby 2.0.0 compatibility
aske pushed a commit to aske/grape-swagger-rails that referenced this pull request Jun 8, 2017
@aske
Fix api key default value (ruby-grape#82)
4c8602b 
* add failing spec

* fix adding api_key_default_value to headers

* update changelog

* bump rubocop to fix rake issue

* add geckodriver to fix issues with new selenium-webdriver

* fix specs

* change gem versions to keep ruby 2.0.0 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konto-andrzeja @dblock