Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/options supported submit methods #57

Merged

Conversation

jnill
Copy link
Contributor

@jnill jnill commented Jun 2, 2016

Adding in the ability to use the supportedSubmitMethods option to hide the "Try it now!" button on different operations. Set default to all and assigning nil is treated as an empty list.

Includes updated README and rspec tests.

@aschuster3
Copy link

I like it, please take a look over at the CONTRIBUTING and follow the steps for adding your contribution.

@jnill jnill force-pushed the feature/options-supportedSubmitMethods branch from 3edf0d9 to c0ef337 Compare June 2, 2016 18:15
@jnill
Copy link
Contributor Author

jnill commented Jun 2, 2016

Sorry about that, updated. Let me know if I should squash it.

@@ -1,6 +1,6 @@
### 0.2.2 (Next)

* Your contribution here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this back please! With a dot at the end ;)

@jnill
Copy link
Contributor Author

jnill commented Jun 2, 2016

Fixed! I also did as @dblock suggested and made the default a ruby code block.

@aschuster3 aschuster3 merged commit 0d8734e into ruby-grape:master Jun 2, 2016
@jnill jnill deleted the feature/options-supportedSubmitMethods branch May 18, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants