-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass extension documentation into schema #64
Pass extension documentation into schema #64
Conversation
Looks good to me, can we add a test to validate the expected behavior? |
Actually, I just modified the current one, to ensure that it works as expected. |
Also, I see that the workflow should be updated with a new Ruby version. I will do it in a separate PR. |
also don't forget to add an entry to the changelog |
done here: #65 |
done here 7245469. |
Thanks! Will merge this in and try to figure out the danger issues separately and get a release out asap. |
Ah I missed this, I had started down the same path: ruby-grape/danger#11 Is that what you were thinking as well? |
Yeah, the same path. Answered here: #65 (comment) |
This PR allows to handle
x-
extension documentation specifically for object type fields in the OpenAPI schema.For example, it helps to make some fields nullable without modifying the referenced object type with a
x-nullable: true
option like:and have in the schema: