Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for minLength and maxLength #40

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

fotos
Copy link
Contributor

@fotos fotos commented Jan 8, 2020

Adds support for minLength, maxLength for Strings (type: String) as described in the Schema Object of the OpenAPI 2.0 specification.

This is very similar to #37.

@fotos fotos force-pushed the string-min-max-length branch from b591c31 to a60d08f Compare January 8, 2020 23:56
@fotos
Copy link
Contributor Author

fotos commented Jan 9, 2020

Needs to be rebased and merged after #41, which fixes the Rubocop build.

@kzaitsev
Copy link
Collaborator

kzaitsev commented Jan 9, 2020

@fotos branch with rubocop was merged, let me know when you are done with this branch.

@fotos fotos force-pushed the string-min-max-length branch from a60d08f to c45f08b Compare January 9, 2020 17:53
@fotos
Copy link
Contributor Author

fotos commented Jan 9, 2020

@Bugagazavr I rebased and now the specs + rubocop are 🌲.

This is ready to be reviewed (and hopefully merged 😄).

@kzaitsev kzaitsev merged commit 5624a07 into ruby-grape:master Jan 9, 2020
@kzaitsev
Copy link
Collaborator

kzaitsev commented Jan 9, 2020

Thank you!

@fotos fotos deleted the string-min-max-length branch January 9, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants