PR for a bunch of open issues #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsway
reviewed
Sep 11, 2020
| @@ -15,24 +15,34 @@ function Get-RubrikVolumeGroup | |||
| .LINK | |||
| https://rubrik.gitbook.io/rubrik-sdk-for-powershell/command-documentation/reference/get-rubrikvolumegroup | |||
|
|
|||
| .EXAMPLE | |||
| Get-RubrikVolumeGroup -Name 'Quokka volumes' | |||
shamsway
reviewed
Sep 11, 2020
|
|
||
| .EXAMPLE | ||
| $currentreport = Get-RubrikReport -name BoringReportName -DetailedObject | ||
| $currentreport.name = "Jaap's QuokkaReport" |
shamsway
reviewed
Sep 11, 2020
| .EXAMPLE | ||
| Get-RubrikReport -Name 'Boring Report' -DetailedObject | Set-RubrikReport -NewName 'Quokka Report' | ||
|
|
||
| This will rename the report named 'Boring Report' to 'Quokka Report' |
|
@jaapbrasser @shamsway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes pretty much everything that has been reported broken. There's a lot of changes so I don't envy whoever made the mistake of picking this up for review.
Related Issue
Resolves #688
Resolves #681
Resolves #679
Resolves #671
Resolves #662
Resolves #660
Resolves #659
Resolves #655
Resolves #654
Resolves #653
Resolves #652
Resolves #651
Resolves #647
Motivation and Context
It solves all problems.
How Has This Been Tested?
Unit tests still pass (except the vfg one, but that has been fixed in the other PR)
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!