Fix issue with long Id's in New-URIString - Issue 656 #657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in our latest module updates (5.0.2) we limit the ID to be a maximum of 100 characters in New-URIString.ps1? This was not in earlier versions of the module and is now breaking the ability to download database backup files.
When you request to download files in the UI or via the API, we submit an AYSNC request to gather those files and zip them up. This process will create a download link. This process has an ID that looks like this "DOWNLOAD_MSSQL_BACKUP_FILES_80377d45-59d7-49b6-9078-2f98b6265e07_da994f8d-cf28-45d0-a10e-4653cc1f04cb:::0" The length of this ID is 106 characters, which causes New-URIString to error out at line 23 with an error "Please validate ID input, invalid ID provided: '$id'" -ErrorAction Stop
Related Issue
Resolve #656
Motivation and Context
This resolve the issue with long restore URIs failing with this private function
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!