Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with long Id's in New-URIString - Issue 656 #657

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Conversation

jaapbrasser
Copy link
Contributor

Description

in our latest module updates (5.0.2) we limit the ID to be a maximum of 100 characters in New-URIString.ps1? This was not in earlier versions of the module and is now breaking the ability to download database backup files.
When you request to download files in the UI or via the API, we submit an AYSNC request to gather those files and zip them up. This process will create a download link. This process has an ID that looks like this "DOWNLOAD_MSSQL_BACKUP_FILES_80377d45-59d7-49b6-9078-2f98b6265e07_da994f8d-cf28-45d0-a10e-4653cc1f04cb:::0" The length of this ID is 106 characters, which causes New-URIString to error out at line 23 with an error "Please validate ID input, invalid ID provided: '$id'" -ErrorAction Stop

Related Issue

Resolve #656

Motivation and Context

This resolve the issue with long restore URIs failing with this private function

Screenshots (if appropriate):

image

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaapbrasser jaapbrasser requested review from shamsway and a team and removed request for shamsway July 7, 2020 18:27
Copy link
Contributor

@shamsway shamsway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shamsway shamsway merged commit 5e35acf into devel Jul 7, 2020
@shamsway shamsway deleted the jaap-656 branch July 7, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New-URIString.ps1 does not allow for IDs longer than 100 characters
2 participants