Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 309 - Individual Snapshot deletion #591

Merged
merged 13 commits into from
Mar 22, 2020
Merged

Issue 309 - Individual Snapshot deletion #591

merged 13 commits into from
Mar 22, 2020

Conversation

mwpreston
Copy link
Contributor

@mwpreston mwpreston commented Mar 19, 2020

Description

This PR adds Remove-RubrikFilesetSnapshot, RemoveRubrikDatabaseSnapshots, Remove-RubrikHyperVSnapshot, Remove-RubrikManagedVolumeSnapshot, Remove-RubrikNutanixVMSnapshot, and Remove-RubrikVolumeGroupSnapshot along with associated unit tests

NOTE Remove-RubrikDatabaseSnapshots deletes ALL snapshots for a given database - there is currently no endpoint to support the deletion of a single snapshot

Also included is the addition of a confirmation prompt to Remove-RubrikVMSnapshot

Related Issue

Issue 309

Motivation and Context

Allows customers to delete expired snapshots manually from their clusters

How Has This Been Tested?

Tested against 5.0 and 5.1 in the TM lab

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mwpreston mwpreston requested a review from shamsway March 19, 2020 17:08
@jaapbrasser jaapbrasser self-requested a review March 22, 2020 15:56
Copy link
Contributor

@jaapbrasser jaapbrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Mike! 👍

@jaapbrasser jaapbrasser merged commit 92c14cd into devel Mar 22, 2020
@jaapbrasser jaapbrasser deleted the mwpreston-309 branch March 22, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants