Update Style/SingleLineMethods
to correct to an endless method definition if they are allowed
#9295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #9281.
If
Style/EndlessMethod
is enabled and not using thedisallow
style, single line methods will be corrected to endless methods instead. My rationale here is that if the user is allowing endless methods, they are a "smaller" correction for single line methods than replacing with a normal method definition.I went back and forth about if this should be configured independently from the
Style/EndlessMethod
configuration. I think it makes sense to keep all the configuration for endless methods in one place, but if we'd rather have it specifically configured forStyle/SingleLineMethods
, I'd be happy to make that change.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.