Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datamapper select incorrectly auto corrected to find #1766

Closed
basex opened this issue Apr 7, 2015 · 0 comments
Closed

Datamapper select incorrectly auto corrected to find #1766

basex opened this issue Apr 7, 2015 · 0 comments

Comments

@basex
Copy link

basex commented Apr 7, 2015

After upgrading the project from rubocop 0.29.1 to 0.30.0 the auto-correct started incorrectly changing the Datamapper select to find.

Diff:

-  DataMapper.repository(:default).adapter.select('select id from ....')
+ DataMapper.repository(:default).adapter.find('select id from ....')
@basex basex mentioned this issue Apr 7, 2015
Merged
@basex basex changed the title Datamapper select auto corrected to Datamapper find Datamapper select auto corrected to find Apr 7, 2015
@basex basex changed the title Datamapper select auto corrected to find Datamapper select incorrectly auto corrected to find Apr 7, 2015
palkan added a commit to palkan/rubocop that referenced this issue Apr 7, 2015
@palkan
[Fix rubocop#1766] Do not register offenses on non-enumerable select/…
6a9b57d 
…find_all
palkan added a commit to palkan/rubocop that referenced this issue Apr 7, 2015
@palkan
[Fix rubocop#1766] Do not register offenses on non-enumerable select/…
2923d28 
…find_all
@bbatsov bbatsov closed this as completed in 3e143e9 Apr 7, 2015
bbatsov added a commit that referenced this issue Apr 7, 2015
@bbatsov
Merge pull request #1767 from palkan/fix-detect-cop
fc26078 
[Fix #1766] Do not register offenses on non-enumerable select/find_all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@basex