forked from covermymeds/rubocop-thread_safety
-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ThreadSafety/RackMiddlewareInstanceVariable
cop
#52
Merged
viralpraxis
merged 19 commits into
rubocop:master
from
viralpraxis:implement-rack-middleware-instance-variable-cop
Sep 26, 2024
Merged
Implement ThreadSafety/RackMiddlewareInstanceVariable
cop
#52
viralpraxis
merged 19 commits into
rubocop:master
from
viralpraxis:implement-rack-middleware-instance-variable-cop
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viralpraxis
force-pushed
the
implement-rack-middleware-instance-variable-cop
branch
from
September 24, 2024 12:00
ff04bb7
to
480c556
Compare
viralpraxis
force-pushed
the
implement-rack-middleware-instance-variable-cop
branch
from
September 25, 2024 07:03
561304a
to
abe9970
Compare
viralpraxis
changed the title
Implement rack middleware instance variable cop
Implement Sep 25, 2024
ThreadSafety/RackMiddlewareInstanceVariable
cop
mikegee
reviewed
Sep 25, 2024
spec/rubocop/cop/thread_safety/rack_middleware_instance_variable_spec.rb
Show resolved
Hide resolved
mikegee
approved these changes
Sep 25, 2024
Amazing! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15
This [baseline] implementation is pretty straightforward. I applied two heuristic here:
app
) and do not report it;This cop also supports
AllowedIdentifiers
concern.