Fix someThreadSafety::InstanceVariableInClassMethod
false positive offenses
#42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28, fixes #16, fixes #13
Detecting
Data.define
,Struct.new
andClass.new
is essentially the same as detectingdefine_method
ancestors.NOTE: there is a common issue for both new and existing logic: we do not check if new-lexical-scope-ancestor is also an ancestor for class method. See https://github.com/viralpraxis/rubocop-thread_safety/blob/9a7e9437aadaf3f6fdbe5e847c19542361f6cd92/spec/rubocop/cop/thread_safety/instance_variable_in_class_method_spec.rb#L108 for false negative example
I'll try to evaluate performance impact and check if it the issue mentioned above is fixable