Skip to content

Commit

Permalink
Merge pull request #54 from viralpraxis/drop-support-for-old-rubocops
Browse files Browse the repository at this point in the history
Drop support for old rubocops
  • Loading branch information
viralpraxis authored Sep 25, 2024
2 parents 31ea459 + 5e6748d commit 8d6bb05
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 22 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,7 @@ jobs:
fail-fast: false
matrix:
ruby: ["2.7", "3.0", "3.1", "3.2", "3.3", ruby-head, jruby-9.4]
rubocop_version: ["0.92", "1.20", "1.66"]
exclude:
- ruby: ruby-head
rubocop_version: "0.92"
- ruby: ruby-head
rubocop_version: "1.20"

rubocop_version: ["1.48", "1.66"]
env:
BUNDLE_GEMFILE: "gemfiles/rubocop_${{ matrix.rubocop_version }}.gemfile"
steps:
Expand Down
8 changes: 2 additions & 6 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
# frozen_string_literal: true

appraise 'rubocop-0.90' do
gem 'rubocop', '~> 0.90.0'
end

appraise 'rubocop-1.20' do
gem 'rubocop', '~> 1.20.0'
appraise 'rubocop-1.48' do
gem 'rubocop', '~> 1.48.0'
end

appraise 'rubocop-1.66' do
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## master (unreleased)

* [#52](https://github.com/rubocop/rubocop-thread_safety/pull/52): Drop support for RuboCop older than 1.48. ([@viralpraxis](https://github.com/viralpraxis))
* [#48](https://github.com/rubocop/rubocop-thread_safety/pull/48): Do not report instance variables in `ActionDispatch` callbacks in singleton methods. ([@viralpraxis](https://github.com/viralpraxis))
* [#43](https://github.com/rubocop/rubocop-thread_safety/pull/43): Make detection of ActiveSupport's `class_attribute` configurable. ([@viralpraxis](https://github.com/viralpraxis))
* [#42](https://github.com/rubocop/rubocop-thread_safety/pull/42): Fix some `InstanceVariableInClassMethod` cop false positive offenses. ([@viralpraxis](https://github.com/viralpraxis))
Expand Down
7 changes: 0 additions & 7 deletions gemfiles/rubocop_1.20.gemfile

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "https://rubygems.org"

gem "rubocop", "~> 0.92.0"
gem "base64", "~> 0.1.1"
gem "rubocop", "~> 1.48.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion rubocop-thread_safety.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = '>= 2.7.0'

spec.add_dependency 'rubocop', '>= 0.92.0'
spec.add_dependency 'rubocop', '>= 1.48.1'

spec.add_development_dependency 'appraisal'
spec.add_development_dependency 'bundler', '>= 1.10', '< 3'
Expand Down

0 comments on commit 8d6bb05

Please sign in to comment.