Add SupportedMethods configuration to RSpec/RedundantPredicateMatcher cop
#2121
+88
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r` cop This PR add SupportedMethods configuration to `RSpec/RedundantPredicateMatcher` cop. Fixes: #2012 This change involves trade-offs. Previously, we could specify replaceable method names in a hard-coded manner, which allowed us to use RESTRICT_ON_SEND. However, now that the decision is based on values set in the config, RESTRICT_ON_SEND can no longer be used. Additionally, since `be_all` requires special internal processing, it's difficult to create this cop generically with Config, leaving special handling for `be_all` inside the implementation. However, this change enables the `ResultPredictedMatcher` cop to determine which cops trigger violations through Config. For example, when using Cucumber, this allows you to exclude only `match` from violations. As mentioned earlier though, this change involves trade-offs, so if these trade-offs are unacceptable, we need to discard this change. I think it's fine to discard it if necessary.
bquorning
approved these changes
Oct 2, 2025
| def on_send(node) | ||
| return if node.parent.block_type? || node.arguments.empty? | ||
| return unless replaceable_arguments?(node) | ||
| return unless !node.parent&.block_type? && !node.arguments.empty? |
There was a problem hiding this comment.
I find this line much harder to read than the original line. We could even change it to
return if node.parent.block_type?
return if node.arguments.empty?However you added a &. so there’s special handling if node.parent.nil?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add SupportedMethods configuration to
RSpec/RedundantPredicateMatchercop.Fixes: #2012
This change involves trade-offs. Previously, we could specify replaceable method names in a hard-coded manner, which allowed us to use RESTRICT_ON_SEND. However, now that the decision is based on values set in the config, RESTRICT_ON_SEND can no longer be used. Additionally, since
be_allrequires special internal processing, it's difficult to create this cop generically with Config, leaving special handling forbe_allinside the implementation.However, this change enables the
ResultPredictedMatchercop to determine which cops trigger violations through Config. For example, when using Cucumber, this allows you to exclude onlymatchfrom violations. As mentioned earlier though, this change involves trade-offs, so if these trade-offs are unacceptable, we need to discard this change. I think it's fine to discard it if necessary.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"inconfig/default.yml.