-
-
Notifications
You must be signed in to change notification settings - Fork 283
Improve an offense message for RSpec/RepeatedExample
cop
#2119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cdc4ccf
to
9a98cc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far 👍🏼
|
||
# 新しいテストケース: 複数の重複がある場合 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# 新しいテストケース: 複数の重複がある場合 |
- Add new cop `RSpec/LeakyLocalVariable`. ([@lovro-bikic]) | ||
- Bump RuboCop requirement to +1.81. ([@ydah]) | ||
- Fix a false positive for `RSpec/LetSetup` when `let!` used in outer scope. ([@ydah]) | ||
- Improve an offense message for `RSpec/RepeatedExample`cop. ([@ydah]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Improve an offense message for `RSpec/RepeatedExample`cop. ([@ydah]) | |
- Improve an offense message for `RSpec/RepeatedExample` cop. ([@ydah]) |
RUBY | ||
end | ||
|
||
it 'shows line numbers for real-world scenario from GitHub issue' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn’t this example covered more or less by it 'correctly reports duplicates with string interpolation' do
in line 139?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes: #1932
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).