Skip to content

Conversation

ydah
Copy link
Member

@ydah ydah commented Oct 2, 2025

Fixes: #1932


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner October 2, 2025 14:52
@ydah ydah force-pushed the 1932 branch 3 times, most recently from cdc4ccf to 9a98cc0 Compare October 2, 2025 15:05
Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍🏼

Comment on lines +92 to +93

# 新しいテストケース: 複数の重複がある場合
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 新しいテストケース: 複数の重複がある場合

- Add new cop `RSpec/LeakyLocalVariable`. ([@lovro-bikic])
- Bump RuboCop requirement to +1.81. ([@ydah])
- Fix a false positive for `RSpec/LetSetup` when `let!` used in outer scope. ([@ydah])
- Improve an offense message for `RSpec/RepeatedExample`cop. ([@ydah])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Improve an offense message for `RSpec/RepeatedExample`cop. ([@ydah])
- Improve an offense message for `RSpec/RepeatedExample` cop. ([@ydah])

RUBY
end

it 'shows line numbers for real-world scenario from GitHub issue' do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t this example covered more or less by it 'correctly reports duplicates with string interpolation' do in line 139?

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSpec/RepeatedExample false positive
3 participants