AutoCorrect: contextual needs rubocop v1.61

[ydah]

https://github.com/rubocop/rubocop/releases/tag/v1.61.0

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• [-] Added tests.
• [-] Updated documentation.
• [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

The is is a big jump
Can we make it together with the 3.0 release, or in 3.x?

How did you catch this?
I see that rubocop/rubocop-rspec_rails@ff9bf2a is ❌, but I don’t see why.
Do we have this build job that checks with the lowest supported rubocop version?

[bquorning]

This makes me a bit hesitant to backport our contextual autocorrection to 2-x-stable.

[bquorning]

Do we have this build job that checks with the lowest supported rubocop version?

That would be https://github.com/rubocop/rubocop-rspec/actions/runs/9355023880/job/25749240673, using gem 'rubocop', '= 1.40' on e49f221.

[bquorning]

I see that rubocop/rubocop-rspec_rails@ff9bf2a is ❌, but I don’t see why.

The failing CI is because rubocop/rubocop-rspec_rails#30 is not (and cannot be) merged yet.

[bquorning]

I’m trying to read rubocop/rubocop#12657 and I think if people are using an older version of RuboCop than v1.61, autocorrect will just keep working as it always has. But if they’re using v1.61+ then they get the new LSP feature too.

In conclusion, I don’t think we need this PR. People who want to use LSP should use RuboCop v1.61+ anyway. But on the other hand, the target branch is master which is targeted at our v3.0, and we can decide to not backport to 2-x-stable, right?

[ydah]

@bquorning Thanks for catching that. You're right, it is indeed. I'm going to close this PR since there is no need to necessarily update version it.

[bquorning]

Yeah, maybe we should have merged this before v3.0.0.
Reopening the PR as maybe we want to do it as a bugfix in v3.0.1?

[ydah]

Let's do that. @pirj WDYT?

[bquorning]

I added one commit, so that merging this PR will release v3.0.1.

I feel like I have been a little too eager to merge and release lately, so I’ll wait for @pirj to review before merging.

[pirj]

Let’s merge and release as 3.0.1, i see no big harm here.

The only problem would be people doing bundle update —conservative rubocop-rspec, which would resolve to 3.0.0 as 3.0.1 would depend on newer rubocop and won’t match.

I’d be most interested in why our CI “oldest rubocop” job didn’t catch this.

[ydah]

In the following sections, if AutoCorrect was set to a value other than boolean, the corresponding error message was output, so it was necessary to update to v1.61. So, let's change it and release it.

https://github.com/rubocop/rubocop/blob/edb56c927d4d1112a9c02990da31767e68d2121c/lib/rubocop/config_validator.rb#L251-L268