Make FilePath check suffix when given a non-constant top-level node

[topalovic]

Currently, RSpec/FilePath matcher ignores non-constant top-level nodes.

However, the standard feature format assumes string descriptions:

RSpec.feature "Some feature" do
end

This can make feature files without a proper suffix go unnoticed and then ignored by the runner. Test it by creating a feature file without a suffix, e.g. spec/features/some_feature.rb.

This PR makes the matcher more general by matching _ instead of const. If the top-level node is not a constant, we'll simply fall back to the basic spec_suffix_only? check, regardless of the actual config flag.

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

Hey @topalovic 👋

Looks good, thank you!

[Darhazer]

Perhaps we can capture just the arguments and deconstruct when needed

$(send #rspec? _example_group $_ $...)

then the usage will be

example_group(node) do |send_node, arguments|

and inside ensure_correct_file_path we would have

example_group, method_name, = *arguments

[pirj]

Won't it result in an internal affairs offence?

# lib/rubocop/cop/rspec/expect_output.rb
          # rubocop:disable InternalAffairs/NodeDestructuring
          variable_name, _rhs = *node
          # rubocop:enable InternalAffairs/NodeDestructuring

[Darhazer]

Only when the variable name ends with node 😂

[topalovic]

I'm not sure I'm up to snuff wrt "internal affairs" or parser intricacies, so I would trust you to refactor the matcher according to your vision :-)

I'm primarily concerned with getting the fix out there, since my own team got burned by trusting RuboCop to warn about feature files without the suffix.

[Darhazer]

Fair enough

[bquorning]

I'm primarily concerned with getting the fix out there

It's released now, as v2.4.0.

[pirj]

I'm not sure why CircleCI doesn't pick up the build https://app.circleci.com/pipelines/github/rubocop/rubocop-rspec
Green locally with RuboCop 1.8.1 and Ruby 2.5.7.