-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark ActiveRecord/Aliases as unsafe autocorrect #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathamesh-sonpatki
force-pushed
the
patch-1
branch
from
July 30, 2019 08:28
2d355b0
to
04e8000
Compare
koic
reviewed
Jul 30, 2019
Could you add a changelog entry? I think the following is an example. |
prathamesh-sonpatki
force-pushed
the
patch-1
branch
from
July 30, 2019 08:59
04e8000
to
d1b5fcf
Compare
prathamesh-sonpatki
changed the title
Make ActiveRecordAliases scope false
Mark ActiveRecordAliases as unsafe autocorrect
Jul 30, 2019
prathamesh-sonpatki
force-pushed
the
patch-1
branch
from
July 30, 2019 09:00
d1b5fcf
to
7d350e5
Compare
prathamesh-sonpatki
changed the title
Mark ActiveRecordAliases as unsafe autocorrect
Mark ActiveRecord/Aliases as unsafe autocorrect
Jul 30, 2019
prathamesh-sonpatki
force-pushed
the
patch-1
branch
2 times, most recently
from
July 30, 2019 09:02
83b0622
to
b15ae49
Compare
@koic Thanks, done! |
prathamesh-sonpatki
force-pushed
the
patch-1
branch
from
July 30, 2019 09:04
b15ae49
to
03525c1
Compare
koic
reviewed
Jul 30, 2019
prathamesh-sonpatki
force-pushed
the
patch-1
branch
from
July 30, 2019 09:10
03525c1
to
7c55d9b
Compare
koic
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks for your quick response!
koic
reviewed
Jul 30, 2019
We faced an issue where our custom `update_attributes` method call was changed to `update` but the method name remained same in the method definition. ```ruby def update_attributes end update_attributes ``` ```ruby def update_attributes end update ``` So the cop is not safe for auto correct.
prathamesh-sonpatki
force-pushed
the
patch-1
branch
from
July 30, 2019 10:20
7c55d9b
to
038af92
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We faced an issue where our custom
update_attributes
method call was changed toupdate
but the method name remained same in the method definition.Original code
After running rubocop --safe-auto-correct:
So the cop is not safe for auto correct.
Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.