Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #941] Remove redundant config for Style/InverseMethods #964

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 29, 2023

Fixes #941.

This PR removes redundant config for Style/InverseMethods. So each invert rule was already supported by the following cops.

  • Rails/Present cop ... present? / blank?
  • Rails/NegateInclude cop ... include? / exclude?

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#941.

This PR removes redundant config for `Style/InverseMethods`.
So each invert rule was already supported by the following cops.

- `Rails/Present` cop ... `present?` / `blank?`
- `Rails/NegateInclude` cop ... `include?` / `exclude?`
@koic koic merged commit 968331c into rubocop:master Mar 30, 2023
@koic koic deleted the remove_redundant_config_for_style_inverse_methods branch September 29, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert default changes to Style/InverseMethods in v2.18
1 participant