Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails/CompactBlank bug when offense is found in block #753

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Aug 3, 2022

I ran autocorrection of Rails/CompactBlank to my code and confirmed that the code is converted as follows:

-hash.transform_values { |value| value.reject(&:blank?) }
+hash.transform_values { |value| value.compact_blank

It appears that the offense range is incorrect.

hash.transform_values { |value| value.reject(&:blank?) }
                                      ^^^^^^^^^^^^^^^^^^ Use `compact_blank` instead.

Both the .reject call within a block and the .reject call with a block have a block node in the parent, so I think it's not sufficient to simply check whether the parent is a block_type?.

$ cat example.rb 
a { b.reject(&:blank?) }

c.reject! { |d| d.blank? }
$ ruby-parse example.rb 
(begin
  (block
    (send nil :a)
    (args)
    (send
      (send nil :b) :reject
      (block-pass
        (sym :blank?))))
  (block
    (send
      (send nil :c) :reject!)
    (args
      (procarg0
        (arg :d)))
    (send
      (lvar :d) :blank?)))

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@r7kamura r7kamura force-pushed the feature/compact-blank branch from a45d474 to 36a246c Compare August 3, 2022 02:35
@r7kamura r7kamura force-pushed the feature/compact-blank branch from 36a246c to 54c123a Compare August 3, 2022 02:37
@r7kamura r7kamura force-pushed the feature/compact-blank branch from 8a02019 to 0d883b5 Compare August 6, 2022 03:14
@koic koic merged commit 949b7a3 into rubocop:master Aug 6, 2022
@koic
Copy link
Member

koic commented Aug 6, 2022

Thanks!

@r7kamura r7kamura deleted the feature/compact-blank branch August 6, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants