[Fix #166] Ignore db/schema and bin #168
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can add the changelog entry for this PR? |
fidalgo
force-pushed
the
ignore-db-schema-and-bin-directory
branch
2 times, most recently
from
a46206b to
da112b9
Compare
|
@koic added the changelog... I don't know why the Ruby HEAD is failing, do you have any clue? |
koic
reviewed
Dec 8, 2019
|
CI failure for Ruby HEAD has been resolved by #169. Can you rebase with the latest master branch? |
fidalgo
force-pushed
the
ignore-db-schema-and-bin-directory
branch
from
da112b9 to
ee3c159
Compare
koic
reviewed
Dec 13, 2019
Since these files are generated by Rails, Rucocop should not report offenses on them. Fixes rubocop#166
fidalgo
force-pushed
the
ignore-db-schema-and-bin-directory
branch
from
ee3c159 to
b1756fe
Compare
|
As |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these files are generated by Rails, Rucocop should not
report offenses on them.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.