Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Rails/RenderPlainText when the content type is passed as a constant #1325

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Earlopain
Copy link
Contributor

Or other nodes that don't respond to value like local variables


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@Earlopain Earlopain changed the title [#1325](https://github.com/rubocop/rubocop-rails/pull/1325): Fix an error for Rails/RenderPlainText when the content type is passed as a constant Fix an error for Rails/RenderPlainText when the content type is passed as a constant Aug 12, 2024
Comment on lines 57 to 61
if pair_node&.value.respond_to?(:value)
pair_node.value.value == 'text/plain'
elsif !pair_node
!cop_config['ContentTypeCompatibility']
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tweak to the following?

Suggested change
if pair_node&.value.respond_to?(:value)
pair_node.value.value == 'text/plain'
elsif !pair_node
!cop_config['ContentTypeCompatibility']
end
if pair_node.nil?
!cop_config['ContentTypeCompatibility']
elsif pair_node.value.respond_to?(:value)
pair_node.value.value == 'text/plain'
end

…sed as a constant

Or other nodes that don't respond to `value` like local variables
@Earlopain Earlopain force-pushed the render-plain-text-error branch from 29ef00e to eecc2bb Compare August 12, 2024 16:25
@koic koic merged commit d4a4ea7 into rubocop:master Aug 12, 2024
14 checks passed
@koic
Copy link
Member

koic commented Aug 12, 2024

Thanks!

@Earlopain Earlopain deleted the render-plain-text-error branch August 12, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants