[Fix #1249] Disable Rails/UnusedIgnoredColumns by default
#1252
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
disable-unused-ignored-columns
branch
from
4ad737c to
8c3ed86
Compare
Earlopain
force-pushed
the
disable-unused-ignored-columns
branch
from
8c3ed86 to
f60be8d
Compare
|
@pocke Do you have any comments on this proposal? If there are no objections, I will proceed with the merge. |
mjankowski
added a commit
to mjankowski/standard-rails
that referenced
this pull request
May 31, 2024
History in standard-rails: - Initially added during a rubocop-rails bump, as pending - Changed to enabled during the RailsConf vote changes Disabled on rubocop-rails side in release 2.25.0 - https://github.com/rubocop/rubocop-rails/releases/tag/v2.25.0 Rationale - rubocop/rubocop-rails#1252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1249
This cop can't be used to effectivly check for unused columns because the development and production schema can be out of sync until the migration has been run on production.
As such, this cop can cause
ignored_columnsto be removed even though the production schema still contains the column, which can lead to downtime when the migration is actually executed.Users can manually enable this cop if they know this isn't an issue that can/will impact them.
cc @rafaelfranca, let me know if the added tidbit to the cops documentation is not correct.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.