Rails/MigrationClassName triggers on inner classes

[tomhughes]

Expected behavior

The Rails/MigrationClassName cop should only trigger on the top level class in a migration.

Actual behavior

The Rails/MigrationClassName cop triggers on the inner classes in a migration.

Steps to reproduce the problem

Consider this example:

class AddEmailValid < ActiveRecord::Migration[4.2]
  class User < ApplicationRecord
  end

  def self.up
    add_column "users", "email_valid", :boolean, :default => false, :null => false
    User.update_all("email_valid = (active != 0)") # email_valid is :boolean, but active is :integer. "email_valid = active" (see r11802 or earlier) will fail for stricter dbs than mysql
  end

  def self.down
    remove_column "users", "email_valid"
  end
end

with rubocop-rails 2.14.0 the inner User class is renamed to AddEmailValid.

RuboCop version

1.26.0 (using Parser 3.1.1.0, rubocop-ast 1.16.0, running on ruby 3.0.2 x86_64-linux)

• rubocop-minitest 0.18.0
• rubocop-performance 1.13.3
• rubocop-rails 2.14.0
• rubocop-rake 0.6.0

[koic]

This issue is a dup with #657.

[koic]

RuboCop Rails 2.14.1 has been released.
https://github.com/rubocop/rubocop-rails/releases/tag/v2.14.1

[tomhughes]

Thanks. Unfortunately I found another failing case now which I've reported as #660.

[mkllnk]

I still see the same behaviour with v2.14.1. Inner classes descending from ActiveRecord::Base are flagged and "corrected".