Fix errors that occur when unrelated tag is investigated by `Rails/…

…ContentTag`
rubocop · Oct 12, 2022 · f34bc2b · f34bc2b
1 parent f361219
commit f34bc2b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/rubocop/cop/rails/content_tag.rb b/lib/rubocop/cop/rails/content_tag.rb
@@ -56,7 +56,8 @@ def allowed_argument?(argument)
             argument.send_type? ||
             argument.const_type? ||
             argument.splat_type? ||
-            allowed_name?(argument)
+            allowed_name?(argument) ||
+            !argument.respond_to?(:value)
         end
 
         def register_offense(node, message, preferred_method)

diff --git a/spec/rubocop/cop/rails/content_tag_spec.rb b/spec/rubocop/cop/rails/content_tag_spec.rb
@@ -174,6 +174,14 @@
       end
     end
 
+    context 'when the first argument is keyword arguments' do
+      it 'does not register an offense' do
+        expect_no_offenses(<<~RUBY)
+          tag(factory: :tag)
+        RUBY
+      end
+    end
+
     context 'when `tag` is not a top-level method (e.g. using intercom-ruby)' do
       it 'does not register an offense' do
         expect_no_offenses(<<~RUBY)