Merge pull request #296 from koic/fix_a_false_negative_for_performanc…

…e_string_identifier_argument Fix a false negative for `Performance/StringIdentifierArgument`
rubocop · Jul 17, 2022 · ac7ceba · ac7ceba
2 parents 36065b7 + 9dbfdd4
commit ac7ceba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog/fix_a_false_negative_for_performance_string_identifier_argument.md b/changelog/fix_a_false_negative_for_performance_string_identifier_argument.md
@@ -0,0 +1 @@
+* [#296](https://github.com/rubocop/rubocop-performance/pull/296): Fix a false negative for `Performance/StringIdentifierArgument` when using `instance_variable_defined?`. ([@koic][])
diff --git a/lib/rubocop/cop/performance/string_identifier_argument.rb b/lib/rubocop/cop/performance/string_identifier_argument.rb
@@ -38,7 +38,7 @@ class StringIdentifierArgument < Base
           remove_class_variable remove_method undef_method class_variable_get class_variable_set
           deprecate_constant module_function private private_constant protected public public_constant
           remove_const ruby2_keywords
-          define_singleton_method instance_variable_defined instance_variable_get instance_variable_set
+          define_singleton_method instance_variable_defined? instance_variable_get instance_variable_set
           method public_method public_send remove_instance_variable respond_to? send singleton_method
           __send__
         ].freeze
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#296](https://github.com/rubocop/rubocop-performance/pull/296): Fix a false negative for `Performance/StringIdentifierArgument` when using `instance_variable_defined?`. ([@koic][])