Merge pull request #197 from krishanbhasin-shopify/master

Fix a false positive for `Minitest/EmptyLineBeforeAssertionMethods`

changelog/fix_false_positive_for_minitest_empty_line_before_assertion_methods.md

@@ -0,0 +1 @@
+* [#189](https://github.com/rubocop/rubocop-minitest/issues/189): Fix a false positive for `Minitest/EmptyLineBeforeAssertionMethods` when using an assertion method as the first line within a test block([@ryanquanz][])

lib/rubocop/cop/minitest/empty_line_before_assertion_methods.rb

@@ -43,8 +43,10 @@ def on_send(node)
         def assertion_method(node)
           return node if assertion_method?(node)
           return unless (parent = node.parent)
+          return unless parent.block_type?
+          return if parent.method?(:test)
 
-          node.parent if parent.block_type? && parent.body && assertion_method?(parent.body)
+          node.parent if parent.body && assertion_method?(parent.body)
         end
 
         def accept_previous_line?(previous_line_node, node)

test/rubocop/cop/minitest/empty_line_before_assertion_methods_test.rb

@@ -385,4 +385,14 @@ def test_does_not_register_offense_when_using_only_non_assertion_method
       do_something(thing)
     RUBY
   end
+
+  def test_does_not_register_offense_when_using_assertion_method_as_first_line_in_test_block_at_top_of_class
+    assert_no_offenses(<<~RUBY)
+      class FooTest < Minitest::Test
+        test "do something" do
+          assert_equal(expected, actual)
+        end
+      end
+    RUBY
+  end
 end