v2.5.9.1 #6175
Merged
v2.5.9.1 #6175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1256042.
This reverts commit b860a55.
This reverts commit 9581ce2.
This reverts commit 2a86641.
Revert dynamic resources
Fix version check crash
Make parser understand multiple line continuations inside lExpressions
This wraps the calls to set and get the enabled state, the visibility and the tag of a CommanBarButton in a check whether it has already been released an logs any attempt the access these methods after the release as a warning. This should lead to a clean exit. However, it only fixes the symptoms of apparently too late CanExecute checks. Identifying these is made difficult by the fact that setting the enabled state is dispatched to the UI thread, which cuts off the stack trace.
This assigns the return value and then exists the function instead of exiting the procedure that gets converted. These two statements are inserted separated by a statement separator instead of doing it on multiple lines to avoid having a separate code path if the Exit Sub is in a single line if statement.
…tSub Replace Exit Sub when converting Subs to Functions
Make the parser understand completely empty single line if statements
Try to avoid RCW exception on CommandBarButtons at shutdown
|
✅ Build Rubberduck 2.5.9.6305 completed (commit 5d040383fd by @retailcoder) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6175 +/- ##
==========================================
- Coverage 97.58% 97.34% -0.24%
==========================================
Files 4 4
Lines 413 413
Branches 28 28
==========================================
- Hits 403 402 -1
Misses 6 6
- Partials 4 5 +1 |
|
✅ Build Rubberduck 2.5.9.6307 completed (commit 9ef33f4040 by @retailcoder) |
It is not safe to convert from Char to int16, since the unicode code points are unsigned 16-bit integers. The safe conversion it to int32, as also indicated in the docs.
Fix unsafe conversion from Char to int
|
✅ Build Rubberduck 2.5.9.6310 completed (commit 707a971d8b by @retailcoder) |
Vogel612
approved these changes
Nov 14, 2023
Fix selection end column if pruning an empty last column
|
✅ Build Rubberduck 2.5.9.6313 completed (commit 4a53f5a150 by @retailcoder) |
|
✅ Build Rubberduck 2.5.9.6315 completed (commit 3e41f9fc8c by @retailcoder) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release recent changes