Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UI setting register #77

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Aug 8, 2023

Description

  • refactor: move workspace uiSettings registration to workspace service
  • refactor: call workspace client init from workspace plugin

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #77 (66ee512) into workspace (8bacb1b) will decrease coverage by 0.52%.
Report is 3 commits behind head on workspace.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           workspace      #77      +/-   ##
=============================================
- Coverage      65.70%   65.19%   -0.52%     
=============================================
  Files           3342     3342              
  Lines          64533    65089     +556     
  Branches       10255    10460     +205     
=============================================
+ Hits           42404    42437      +33     
- Misses         19597    20124     +527     
+ Partials        2532     2528       -4     
Flag Coverage Δ
Linux_1 34.53% <ø> (?)
Linux_3 42.42% <50.00%> (-0.17%) ⬇️
Windows_1 34.69% <ø> (+<0.01%) ⬆️
Windows_2 54.48% <100.00%> (+<0.01%) ⬆️
Windows_3 42.59% <50.00%> (+<0.01%) ⬆️
Windows_4 34.73% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/public/workspace/workspaces_service.ts 33.33% <ø> (+6.06%) ⬆️
src/core/server/server.ts 98.92% <ø> (ø)
src/core/server/ui_settings/settings/index.ts 100.00% <ø> (ø)
src/core/server/workspaces/ui_settings.ts 100.00% <100.00%> (ø)
src/core/server/workspaces/workspaces_service.ts 65.00% <100.00%> (+1.84%) ⬆️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanyl ruanyl merged commit 7715023 into workspace Aug 9, 2023
90 of 99 checks passed
@ruanyl ruanyl deleted the refactor-ui-setting-register branch August 25, 2023 02:51
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
refactor: move workspace uiSettings registration to workspace service

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
refactor: move workspace uiSettings registration to workspace service

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl added a commit that referenced this pull request Sep 15, 2023
refactor: move workspace uiSettings registration to workspace service

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants