Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update public workspace #70

Closed
wants to merge 1 commit into from

Conversation

SuZhou-Joe
Copy link
Collaborator

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe SuZhou-Joe marked this pull request as draft August 1, 2023 10:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #70 (03b1122) into workspace (2996177) will decrease coverage by 5.09%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##           workspace      #70      +/-   ##
=============================================
- Coverage      65.85%   60.76%   -5.09%     
=============================================
  Files           3341     2903     -438     
  Lines          64393    56520    -7873     
  Branches       10052     8855    -1197     
=============================================
- Hits           42403    34343    -8060     
- Misses         19595    20235     +640     
+ Partials        2395     1942     -453     
Flag Coverage Δ
Linux_1 34.69% <100.00%> (+<0.01%) ⬆️
Linux_3 42.80% <50.00%> (-0.01%) ⬇️
Windows_1 34.71% <100.00%> (+<0.01%) ⬆️
Windows_2 54.57% <50.00%> (+<0.01%) ⬆️
Windows_3 42.81% <50.00%> (+<0.01%) ⬆️
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../core/public/saved_objects/saved_objects_client.ts 89.21% <ø> (ø)
...ved_objects/service/lib/search_dsl/query_params.ts 83.69% <0.00%> (ø)
..._objects/workspace_saved_objects_client_wrapper.ts 5.66% <ø> (ø)
src/core/utils/constants.ts 100.00% <100.00%> (ø)

... and 690 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants