Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply workspace permission check when saving object #58

Closed
wants to merge 1 commit into from

Conversation

raintygao
Copy link
Collaborator

Description

apply workspace permission check when saving object

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: tygao <tygao@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #58 (6af0dbe) into workspace (210d3c5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           workspace      #58      +/-   ##
=============================================
- Coverage      65.86%   65.85%   -0.01%     
=============================================
  Files           3337     3337              
  Lines          64339    64346       +7     
  Branches       10043    10045       +2     
=============================================
  Hits           42374    42374              
- Misses         19472    19479       +7     
  Partials        2493     2493              
Flag Coverage Δ
Linux_1 34.69% <ø> (ø)
Linux_3 42.83% <0.00%> (-0.01%) ⬇️
Windows_1 34.71% <ø> (ø)
Windows_2 54.54% <0.00%> (-0.02%) ⬇️
Windows_3 42.84% <0.00%> (-0.01%) ⬇️
Windows_4 34.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._objects/workspace_saved_objects_client_wrapper.ts 5.26% <0.00%> (-0.74%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raintygao raintygao closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants