feature: cannot delete last admin user/group in workspace settings #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Codecov Report
@@ Coverage Diff @@
## workspace #235 +/- ##
=============================================
+ Coverage 66.19% 66.21% +0.01%
=============================================
Files 3431 3438 +7
Lines 65952 66262 +310
Branches 10616 10691 +75
=============================================
+ Hits 43659 43876 +217
- Misses 19645 19704 +59
- Partials 2648 2682 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SuZhou-Joe
reviewed
Oct 19, 2023
src/plugins/workspace/public/components/workspace_creator/workspace_creator.tsx
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Oct 19, 2023
Comment on lines
362
to
363
| const [userNonDeletableIndex, setUserNonDeletableIndex] = useState<number>(-1); | ||
| const [groupNonDeletableIndex, setGroupNonDeletableIndex] = useState<number>(-1); |
There was a problem hiding this comment.
These two states are derived values from userPermissionSettings, groupPermissionSettings, I do not think it is a good practice to declare these two states. You can get these two value by using
const { userNonDeletableIndex, groupNonDeletableIndex } = useMemo(() => {}, [userPermissionSettings, groupPermissionSettings]);
There was a problem hiding this comment.
Thanks, I will update this.
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
wanglam
reviewed
Oct 19, 2023
...plugins/workspace/public/components/workspace_creator/workspace_permission_setting_panel.tsx
Show resolved
Hide resolved
wanglam
approved these changes
Oct 19, 2023
SuZhou-Joe
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In workspace update page, users cannot delete the last user or group with admin permission.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr