Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Refractor] Feature flag (#102)" #124

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Sep 5, 2023

This reverts commit e2f277c.

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #124 (a43373f) into workspace (220bb9d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace     #124      +/-   ##
=============================================
- Coverage      65.77%   65.76%   -0.01%     
=============================================
  Files           3337     3337              
  Lines          64497    64497              
  Branches       10267    10267              
=============================================
- Hits           42421    42416       -5     
- Misses         19500    19502       +2     
- Partials        2576     2579       +3     
Flag Coverage Δ
Linux_1 ?
Linux_3 42.64% <ø> (ø)
Windows_1 34.77% <ø> (ø)
Windows_2 54.74% <ø> (ø)
Windows_3 42.64% <ø> (ø)
Windows_4 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanyl ruanyl force-pushed the revert-runtime-workspace-feature-flag branch from a43373f to 6e04b2e Compare September 6, 2023 05:10
@ruanyl ruanyl merged commit 58605a8 into workspace Sep 6, 2023
43 of 79 checks passed
SuZhou-Joe pushed a commit that referenced this pull request Sep 6, 2023
* Revert "[Refractor] Feature flag (#102)"

This reverts commit e2f277c.
@opensearch-workspace-development

The backport to workspace-2.9 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 workspace-2.9
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9
# Create a new branch
git switch --create backport/backport-124-to-workspace-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58605a8033319178ac15e6c9496cb48e79255bde
# Push it to GitHub
git push --set-upstream origin backport/backport-124-to-workspace-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9

Then, create a pull request where the base branch is workspace-2.9 and the compare/head branch is backport/backport-124-to-workspace-2.9.

@ruanyl ruanyl deleted the revert-runtime-workspace-feature-flag branch September 7, 2023 03:57
SuZhou-Joe pushed a commit that referenced this pull request Sep 11, 2023
* Revert "[Refractor] Feature flag (#102)"

This reverts commit e2f277c.
ruanyl added a commit that referenced this pull request Sep 15, 2023
* Revert "[Refractor] Feature flag (#102)"

This reverts commit e2f277c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants