Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace switch #11

Closed
wants to merge 3 commits into from
Closed

Conversation

raintygao
Copy link
Collaborator

Description

add workspace switch

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
import { useCallback } from 'react';
import { useOpenSearchDashboards } from '../../../../../plugins/opensearch_dashboards_react/public';

export const WorkspaceSwitch = () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raintygao With @SuZhou-Joe 's latest commit, switching workspace would simply be a url navigation, I think the workspace list can be simply a list of links, which navigate to url ?_workspace_id_=<workspace_id>

@ruanyl
Copy link
Owner

ruanyl commented Jun 15, 2023

Is this PR similar to this one #9?

@raintygao
Copy link
Collaborator Author

Yes, I have realized this. I think the task assigned to me may only need to call navigate instead of any UI component. Will update and sync in scrum meeting.

@SuZhou-Joe
Copy link
Collaborator

Yes, I have realized this. I think the task assigned to me may only need to call navigate instead of any UI component. Will update and sync in scrum meeting.

There is a method called "formatUrlWithWorkspaceId" in workspaces.client. You can make use of that to get the jumping url.

@raintygao
Copy link
Collaborator Author

This pull request is based on #9. Waiting for it merged.

@raintygao
Copy link
Collaborator Author

Used a new branch and switched to a new PR.#17 . This PR will be closed.

@raintygao raintygao closed this Jun 16, 2023
@raintygao raintygao mentioned this pull request Jun 16, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants