-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace switch #11
Workspace switch #11
Conversation
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
import { useCallback } from 'react'; | ||
import { useOpenSearchDashboards } from '../../../../../plugins/opensearch_dashboards_react/public'; | ||
|
||
export const WorkspaceSwitch = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raintygao With @SuZhou-Joe 's latest commit, switching workspace would simply be a url navigation, I think the workspace list can be simply a list of links, which navigate to url ?_workspace_id_=<workspace_id>
Is this PR similar to this one #9? |
Yes, I have realized this. I think the task assigned to me may only need to call navigate instead of any UI component. Will update and sync in scrum meeting. |
There is a method called "formatUrlWithWorkspaceId" in workspaces.client. You can make use of that to get the jumping url. |
This pull request is based on #9. Waiting for it merged. |
Used a new branch and switched to a new PR.#17 . This PR will be closed. |
Description
add workspace switch
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr