-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loom
in rtic-common
and rtic-sync
. Fix rtic-sync
bug.
#1027
Open
datdenkikniet
wants to merge
17
commits into
rtic-rs:master
Choose a base branch
from
datdenkikniet:loom2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c3fa07
to
b3f7be8
Compare
fae1035
to
0bbd46d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--cfg loom
support tortic-common
andrtic-sync
.Additionally, adds a test for an
rtic-sync
bug & fixes it (I cannot find the bug report itself here on github).Perhaps splitting out the bug fix into its own PR (d8f8a15) is desirable. I can do that if we deem that it makes sense.
Fixes #780
A description of the path leading to the bug, which also proves that the fix actually solves the problem:
try_recv
pushes intofreeq
.wait_queue
, an interrupt occurs.send
no. 1 eats up thefreeq
slot.send
no. 2 is called, pushes its link towait_queue
and goes to sleep (becausefreeq
is now empty)try_recv
, which popswait_queue
(from the newly waitingsend
call) without touching the free queue.send
is awoken at some point. Its link is popped, but thefreeq
is empty.