Fix pseudo elements and classes not resolving when chained with each
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix issue #140 .
While working on the fix, I noticed that
mapLastis used instead ofList.mapwhen resolving chained pseudo classes. @rtfeldman even though I changed it toList.map, I can't figure out if it's a correct assumption thatmapLastwas at fault here. Could I have regressed something by changing it toList.map? I've thought about it, and couldn't find a scenario that would fail tests.Also, while working on it, I realised the same issue applied to pseudo elements, so I fixed that as well, and introduced a nice refactor to remove some duplication.
Thoughts and concerns? :)