Line Disconnection bug in _BackendAction fix #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update_state method. The previous implementation of the method disables line with idx (0, -1) sometimes due to an indexing error.
|
Hello, Thanks a lot for this pull request and nice catch of this bug ! I will have a look at the code you joined and try to submit you a PR with the proper test. Once merged into your code, I will merge it here. I think it will be better that there is a identified test before merging (to prevent any reappearing of this bug) Benjamin |
|
Hi Benjamin, Thanks for adding the tests. |
|
Hi :-) Can you merge the pull request I made here: anton-musrevinu#1 Once done, I will merge this PR to the main repo. Thanks :-) |
Adding test for PR rte-france#319
|
Sounds good, I just merged the tests :) |
BDonnot
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an indexing error int the update_state method of the _BackendAction lines with idx 0 and -1(and sometimes 1) are sometimes disconnected.
A script to reproduce the bug is given below. Here a seed was found that produces the bug after a few steps.
reproduce_stepping_bug.zip